From b8e326118059688ea3f8a4c4328949348dccddcc Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 13:45:10 +0200 Subject: [PATCH 1/9] Update session.inc.php Using ${var} in strings is deprecated, use {$var} instead --- includes/session.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/session.inc.php b/includes/session.inc.php index 9b359c3..d2209fd 100644 --- a/includes/session.inc.php +++ b/includes/session.inc.php @@ -52,7 +52,7 @@ function _check_csrf_token($user) { } define('CSRF_TOKEN', $csrf_token); - header("X-CSRF-Token: ${csrf_token}"); + header("X-CSRF-Token: {$csrf_token}"); } function enc_secret($message) { From e38fa1e120952b335072943cf3e206f7e829e833 Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 13:57:08 +0200 Subject: [PATCH 2/9] Update ApiHandler.php Creation of dynamic property ApiHandler::$headers is deprecated --- includes/class/ApiHandler.php | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/includes/class/ApiHandler.php b/includes/class/ApiHandler.php index 8653974..177f2b2 100644 --- a/includes/class/ApiHandler.php +++ b/includes/class/ApiHandler.php @@ -3,6 +3,17 @@ include_once('includes/config.inc.php'); class ApiHandler { + public $headers; + public hostname; + public port; + public auth; + public proto; + public sslverify; + public curlh; + public method; + public content; + public apiurl; + public function __construct() { global $apiip, $apiport, $apipass, $apiproto, $apisslverify; From c327e2385951c9bff4d231a39e633cbca6af3abb Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 14:03:20 +0200 Subject: [PATCH 3/9] Update session.inc.php Passing null to parameter #2 ($value) of type string is deprecated --- includes/session.inc.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/session.inc.php b/includes/session.inc.php index d2209fd..1900256 100644 --- a/includes/session.inc.php +++ b/includes/session.inc.php @@ -122,13 +122,13 @@ function dec_secret($code) { function _unset_cookie($name) { $is_ssl = isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off'; - setcookie($name, null, -1, null, null, $is_ssl); + setcookie($name, "", -1, "", "", $is_ssl); } function _store_auto_login($value) { $is_ssl = isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off'; // set for 30 days - setcookie('NSEDIT_AUTOLOGIN', $value, time()+60*60*24*30, null, null, $is_ssl); + setcookie('NSEDIT_AUTOLOGIN', $value, time()+60*60*24*30, "", "", $is_ssl); } function try_login() { From 607ecbd9f2935b72af6a4f1ac9c1dae1f7918ff9 Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 14:06:52 +0200 Subject: [PATCH 4/9] forgot $ --- includes/class/ApiHandler.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/includes/class/ApiHandler.php b/includes/class/ApiHandler.php index 177f2b2..7eb6eb0 100644 --- a/includes/class/ApiHandler.php +++ b/includes/class/ApiHandler.php @@ -4,15 +4,15 @@ include_once('includes/config.inc.php'); class ApiHandler { public $headers; - public hostname; - public port; - public auth; - public proto; - public sslverify; - public curlh; - public method; - public content; - public apiurl; + public $hostname; + public $port; + public $auth; + public $proto; + public $sslverify; + public $curlh; + public $method; + public $content; + public $apiurl; public function __construct() { global $apiip, $apiport, $apipass, $apiproto, $apisslverify; From d59da92f377ca65e4540d371dcb4e7f599f5d87c Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 14:12:30 +0200 Subject: [PATCH 5/9] Update PdnsApi.php Creation of dynamic property PdnsAPI::$http is deprecated --- includes/class/PdnsApi.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/includes/class/PdnsApi.php b/includes/class/PdnsApi.php index 0f9d8b7..404a22c 100644 --- a/includes/class/PdnsApi.php +++ b/includes/class/PdnsApi.php @@ -3,6 +3,9 @@ include_once('ApiHandler.php'); class PdnsAPI { + public $http; + + public function __construct() { $this->http = new ApiHandler(); } From 7c509646330f916a11872bd23f680a0abd0c6edc Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 14:13:08 +0200 Subject: [PATCH 6/9] Update ApiHandler.php --- includes/class/ApiHandler.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includes/class/ApiHandler.php b/includes/class/ApiHandler.php index 7eb6eb0..d793cf0 100644 --- a/includes/class/ApiHandler.php +++ b/includes/class/ApiHandler.php @@ -13,6 +13,8 @@ class ApiHandler { public $method; public $content; public $apiurl; + public $url; + public $json; public function __construct() { global $apiip, $apiport, $apipass, $apiproto, $apisslverify; From cae4e4ff93bc1c329534447cbe1f81258c49ae82 Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 14:14:45 +0200 Subject: [PATCH 7/9] Update Zone.php --- includes/class/Zone.php | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/includes/class/Zone.php b/includes/class/Zone.php index a429550..4be6cdd 100644 --- a/includes/class/Zone.php +++ b/includes/class/Zone.php @@ -1,6 +1,21 @@ id = ''; $this->name = ''; From 758a021ca2e3d2ba89a2a45d5888ebf5e4865b81 Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 14:22:36 +0200 Subject: [PATCH 8/9] Update Zone.php --- includes/class/Zone.php | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/includes/class/Zone.php b/includes/class/Zone.php index 4be6cdd..80d9fdb 100644 --- a/includes/class/Zone.php +++ b/includes/class/Zone.php @@ -236,6 +236,13 @@ class Zone { } class RRSet { + public $name; + public $type; + public $ttl; + public $changetype; + public $records; + public $comments; + public function __construct($name = '', $type = '', $content = '', $disabled = FALSE, $ttl = 3600, $setptr = FALSE) { $this->name = $name; $this->type = $type; @@ -321,6 +328,10 @@ class RRSet { } class Record { + public $content; + public disabled; + public $setptr; + public function __construct($content, $disabled = FALSE, $setptr = FALSE) { $this->content = $content; $this->disabled = $disabled; @@ -341,6 +352,10 @@ class Record { } class Comment { + public $content; + public $account; + public $modified_at; + public function __construct($content, $account, $modified_at) { $this->content = $content; $this->account = $account; From b7ef64db18f540002f94bb95d02d19a30fb6fc97 Mon Sep 17 00:00:00 2001 From: Jelle Luteijn Date: Tue, 20 Jun 2023 14:24:17 +0200 Subject: [PATCH 9/9] Update Zone.php --- includes/class/Zone.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class/Zone.php b/includes/class/Zone.php index 80d9fdb..79cb237 100644 --- a/includes/class/Zone.php +++ b/includes/class/Zone.php @@ -329,7 +329,7 @@ class RRSet { class Record { public $content; - public disabled; + public $disabled; public $setptr; public function __construct($content, $disabled = FALSE, $setptr = FALSE) {